Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix iOS problem with scroll not working in Safari #464

Merged
merged 1 commit into from Jan 8, 2021

Conversation

vvoral
Copy link
Contributor

@vvoral vvoral commented Jan 7, 2021

Close #462

…efModal on container above as its ancestor
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #464 (7af86ce) into master (3e9201d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #464   +/-   ##
=======================================
  Coverage   97.20%   97.20%           
=======================================
  Files           6        6           
  Lines         179      179           
  Branches       65       66    +1     
=======================================
  Hits          174      174           
  Misses          5        5           
Impacted Files Coverage Δ
react-responsive-modal/src/index.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e9201d...7af86ce. Read the comment docs.

@vvoral
Copy link
Contributor Author

vvoral commented Jan 8, 2021

cc. @pradel could you check?

@pradel pradel changed the title [fix] fix iOS problem with bodylock on modal itself in Safari, move r… fix: fix iOS problem with scroll not working in Safari Jan 8, 2021
@pradel pradel merged commit 0e38605 into pradel:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v6 can't scroll on iOS
2 participants