Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use body-scroll-lock instead of no-scroll #455

Merged
merged 7 commits into from Nov 15, 2020

Conversation

pradel
Copy link
Owner

@pradel pradel commented Nov 15, 2020

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2020

size-limit report 📦

Path Size
dist/react-responsive-modal.cjs.production.min.js 3.73 KB (+15.4% 🔺)
dist/react-responsive-modal.esm.js 3.67 KB (+11.6% 🔺)

@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #455 (9baf6d5) into master (5727913) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
+ Coverage   97.17%   97.20%   +0.03%     
==========================================
  Files           5        6       +1     
  Lines         177      179       +2     
  Branches       67       65       -2     
==========================================
+ Hits          172      174       +2     
  Misses          5        5              
Impacted Files Coverage Δ
react-responsive-modal/src/utils.ts 100.00% <ø> (ø)
react-responsive-modal/src/index.tsx 100.00% <100.00%> (ø)
react-responsive-modal/src/modalManager.ts 100.00% <100.00%> (ø)
react-responsive-modal/src/useScrollLock.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5727913...9baf6d5. Read the comment docs.

@pradel pradel marked this pull request as ready for review November 15, 2020 13:44
@pradel pradel merged commit 033f901 into master Nov 15, 2020
@pradel pradel deleted the feature/use-body-scroll-lock branch November 15, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant