Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use hook with modal manager #453

Merged
merged 1 commit into from Nov 15, 2020

Conversation

pradel
Copy link
Owner

@pradel pradel commented Nov 15, 2020

No description provided.

@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #453 (5ffbade) into master (9a06a62) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
+ Coverage   97.05%   97.07%   +0.01%     
==========================================
  Files           5        5              
  Lines         170      171       +1     
  Branches       62       61       -1     
==========================================
+ Hits          165      166       +1     
  Misses          5        5              
Impacted Files Coverage Δ
react-responsive-modal/src/index.tsx 100.00% <100.00%> (ø)
react-responsive-modal/src/modalManager.ts 100.00% <100.00%> (ø)
react-responsive-modal/src/utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a06a62...5ffbade. Read the comment docs.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/react-responsive-modal.cjs.production.min.js 3.13 KB (-0.29% 🔽)
dist/react-responsive-modal.esm.js 3.18 KB (-0.16% 🔽)

@pradel pradel merged commit b016ec4 into master Nov 15, 2020
@pradel pradel deleted the feature/refactor-nodal-manager-hook branch November 15, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant