Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Mistakes in Ch4/01_OnePipeline_ManyClassifiers.ipynb #75

Open
kgdunn opened this issue Aug 18, 2021 · 5 comments
Open

[BUG] Mistakes in Ch4/01_OnePipeline_ManyClassifiers.ipynb #75

kgdunn opened this issue Aug 18, 2021 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@kgdunn
Copy link

kgdunn commented Aug 18, 2021

In: Ch4/01_OnePipeline_ManyClassifiers.ipynb

1/ In cell 14, related to SVM: there is a copy/paste error in the comment, referring to Logistic regression, when the code in that cell is only regarding SVM.

2/ The AUC metric calculated here for SVM calculates something, but it is the AUC for the prior cell, for logistic regression. As seen by the duplicated values.

@kgdunn kgdunn added the bug Something isn't working label Aug 18, 2021
@varunp2k
Copy link
Collaborator

Okay, not sure that went wrong here. Let me look into this over the weekend.

@varunp2k
Copy link
Collaborator

Okay it seems to be an error on our side. @kgdunn would you want to send a pr to fix this?

@kgdunn
Copy link
Author

kgdunn commented Aug 29, 2021 via email

@kartikay-bagla
Copy link
Collaborator

On the contrary, I believe that this would be another learning opportunity.

@Ethan0456
Copy link
Collaborator

This issue is resolved in PR #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants