Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing configure script in 2.5.0 release #477

Open
vostrelt opened this issue Feb 5, 2024 · 4 comments
Open

Missing configure script in 2.5.0 release #477

vostrelt opened this issue Feb 5, 2024 · 4 comments

Comments

@vostrelt
Copy link

vostrelt commented Feb 5, 2024

Hello there,

previous releases had configure scripts shipped with them. I understand that starting from version 2.5.0, automake is used. However, wouldn't it be better to generate the configure scripts for the releases?

Thanks for your work, Tomáš

@paulusmack
Copy link
Collaborator

@enaess how do we get a pre-built configure script included in the generated tarball?

@enaess
Copy link
Contributor

enaess commented Feb 13, 2024

As a part of the release process one should run

./autogen.sh
# configure runs ...
make dist-gzip

This should create the tarball (ppp-2.5.1.tar.gz) that is to be released and includes the configure script. Now, if you use GitHub to tag / create a release, the entire source tree is zipped up as "release evidence". This is different than the .tar.gz generated by the automake scripts which is the release tarball (which does not include autogen.sh, but does include configure).

@paulusmack

@rfc1036
Copy link
Contributor

rfc1036 commented Mar 17, 2024

Since distributions want to generate the configure script at build time and random users are not really supposed to build ppp themselves then I think that it is totally fine if they also have to run autogen.sh.

@enaess
Copy link
Contributor

enaess commented Mar 17, 2024

@rfc1036 I think requiring a package to run 'autogen.sh' brings along a bunch of extra dependencies for the package to build.

You as a packager may see something different in practice, but I'd say most projects do not distribute the autogen.sh, it's used by developers to bootstrap the build.

This is why I suggested just follow the intended design and omit the autogen.sh and to use configure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants