Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epic: html is not escaped #324

Open
machow opened this issue Apr 29, 2024 · 1 comment
Open

epic: html is not escaped #324

machow opened this issue Apr 29, 2024 · 1 comment
Labels
.epic Big features and initiatives Type: ☹︎ Bug

Comments

@machow
Copy link
Collaborator

machow commented Apr 29, 2024 •
edited

#14 mentions the intended behavior in Great Tables is to escape html, unless someone uses html(). However, as our sports earning example shows, HTML in the cell body is not escaped.

This is mentioned here: #134 (comment)

We need to decide what to do, and resolve this. It's likely people are already using this behavior, so we should be careful to take that into account.
@machow machow changed the title html is not escaped epic: html is not escaped May 23, 2024
@machow machow added the .epic Big features and initiatives label May 23, 2024
@machow
Copy link
Collaborator Author

machow commented May 23, 2024

Related to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
.epic Big features and initiatives Type: ☹︎ Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@machow