You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No dependency: _tbl_data.py: this is where we've consolidated all our DataFrame library specific code. It's handled using databackend, so we don't need to depend on these libraries to do isinstance checks on them, etc...
Dependency: _utils_nanoplots.py, _data_color/base.py. This uses numpy in two ways.
Detecting np.integer. This could be moved to _tbl_data.py
Performing calculations. Functions like np.linspace(), and np.mean() should be re-implemented internally. We don't use too many numpy functions, so it hopefully isn't too nuts to do.
Note that for replacing numpy in performing calculations, we should be careful to ensure tests are in place / added where needed. We have good coverage, but I'm not sure it covers every numpy path.
The text was updated successfully, but these errors were encountered:
It seems okay to keep it around in tests. Since pandas can wrap numpy, and return numpy typed objects, we might need it in tests to validate that functions do the right things for a few numpy objects (which might make it in via pandas, etc..)
machow
changed the title
Remove numpy as a dependency
epic: Remove numpy as a dependency
May 23, 2024
Currently, we use numpy in two places:
_tbl_data.py
: this is where we've consolidated all our DataFrame library specific code. It's handled using databackend, so we don't need to depend on these libraries to do isinstance checks on them, etc..._utils_nanoplots.py
,_data_color/base.py
. This uses numpy in two ways._tbl_data.py
np.linspace()
, andnp.mean()
should be re-implemented internally. We don't use too many numpy functions, so it hopefully isn't too nuts to do.Note that for replacing numpy in performing calculations, we should be careful to ensure tests are in place / added where needed. We have good coverage, but I'm not sure it covers every numpy path.
The text was updated successfully, but these errors were encountered: