Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary top-level imports #293

Open
machow opened this issue Apr 16, 2024 · 1 comment
Open

Remove unnecessary top-level imports #293

machow opened this issue Apr 16, 2024 · 1 comment

Comments

@machow
Copy link
Collaborator

machow commented Apr 16, 2024 •
edited

Based on convo w/ @rich-iannone, it seems like there may be some unused helper functions exposed at the top-level (e.g. letters, LETTERS, px). Let's go through the top-level imports and decide which need to stay, and which might be removed.

related to #289 (review)
@jrycw
Copy link
Contributor

jrycw commented Apr 17, 2024

Perhaps it's a good time to incorporate this cleanup with #119 isort?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@machow @jrycw