Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanoplots: If x_vals is passed it silently overrides line_type curved to be straight #256

Open
machow opened this issue Mar 28, 2024 · 0 comments

Comments

@machow
Copy link
Collaborator

machow commented Mar 28, 2024

Currently, if you try to specify line_type curved, but also supply x_vals, we quietly set line_type back to straight.

_generate_nanoplot(
    y_vals=[1, 2, 3],
    x_vals=[2, 4, 6],
    show_data_line=True,
    plot_type="line",
    line_type="curved"
)

If we want to do this, then let's add a guard for x_vals at the very top, that does this one thing (warns user, and overrides their option). That way it will be very easy for us to spot, and users will know what's happening.

Currently, it happens pretty high up, but there's a little bit of extra processing that's going on in tandem.

@rich-iannone rich-iannone changed the title nanoplots: If x_vals is passed it silently overrids line_type curved to be straight nanoplots: If x_vals is passed it silently overrides line_type curved to be straight Apr 5, 2024
@rich-iannone rich-iannone added this to the v0.5.0 milestone Apr 5, 2024
@rich-iannone rich-iannone modified the milestones: v0.5.0, v0.6.0 Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants