Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar in overlay mode briefly becomes transparent when closing #249

Open
nan-af opened this issue Jun 7, 2020 · 3 comments
Open

Sidebar in overlay mode briefly becomes transparent when closing #249

nan-af opened this issue Jun 7, 2020 · 3 comments

Comments

@nan-af
Copy link

nan-af commented Jun 7, 2020

Screenshot

After clicking on the sidebar button to close the sidebar when it's in overlay mode, it goes transparent-ish and looks ugly. This is a problem only during the transition as the sidebar is not visible anyways when it's closed.

This glitch is most noticeable on mobile devices because the sidebar actually comes over the content.

Steps to reproduce:

  1. Enable sidebar-overlay
  2. Open the site in Chrome on desktop
  3. Open developer tools and switch to mobile layout
  4. Set the animation speed to 10%
  5. Open and close the sidebar
@erlete
Copy link

erlete commented Dec 17, 2021

Add a z-index: 0; in the .wrap class and a z-index: 1; in the .sidebar one and the issue should be solved. Even in mobile layout.

@nan-af
Copy link
Author

nan-af commented Dec 18, 2021

@erlete Thanks a lot! Should we make a pull request?

@erlete
Copy link

erlete commented Dec 21, 2021

@erlete Thanks a lot! Should we make a pull request?

Go ahead and make it if you want :) but it seems like the project is currently discontinued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants