Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New props maybe ? #6

Open
Khachatour opened this issue Nov 2, 2018 · 4 comments
Open

New props maybe ? #6

Khachatour opened this issue Nov 2, 2018 · 4 comments

Comments

@Khachatour
Copy link

Hey there! Awesome thing right here thanks!
Only one suggestion, what you think ? Maybe there can be showDirectorInfo or something like that boolean prop to allow control visibility of Director more easily ?

export default class extends React.PureComponent {
  constructor(props) {
    super(props);
    props.showDirectorInfo && showDirector();
  }
  render() {
    return this.props.children;
  }
}
@pomber
Copy link
Owner

pomber commented Nov 5, 2018

Good idea. Wanna send a PR?
It's better if the prop is negated like hideDebugger so we can default it to false. Also we need to hide/show the Director when the prop changes in componentDidUpdate.

@Khachatour
Copy link
Author

Yes, sure :) I'll write it asap :)

@Khachatour
Copy link
Author

@pomber Sorry for the very late reply. Today I eventually get my hands back to this awesome project. So after the initial run, I've encountered an error regarding flatmap-stream and event-stream it is now removed. It is the package which contained a security vulnerability. I want to inform you about this, and decide what to do 😄

@pomber
Copy link
Owner

pomber commented Dec 9, 2018

I just tried a fresh clone and didn't get the error. When are you getting it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants