Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateDom in createDom function #40

Open
Kuuga46 opened this issue Mar 22, 2022 · 2 comments
Open

updateDom in createDom function #40

Kuuga46 opened this issue Mar 22, 2022 · 2 comments

Comments

@Kuuga46
Copy link

Kuuga46 commented Mar 22, 2022

I don't understand why we excute 'updateDom' in the function 'createDom'.It seems that we would change the dom before 'commit',and that should not happen in 'performUnitOfWork'
image

@Kuuga46
Copy link
Author

Kuuga46 commented Mar 23, 2022

I found the reason:
image

image

@ZhaoTim
Copy link

ZhaoTim commented Aug 10, 2022

updateDom方法貌似只是用来处理dom元素的一些attributes以及一些事件绑定,创建了dom以后不就应该即可绑定属性、事件吗?而且updateDom里的逻辑也不存在把dom挂载到页面的行为,应该没问题吧?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants