Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconciliation is too naive #19

Open
RobinClowers opened this issue Nov 20, 2019 · 1 comment
Open

Reconciliation is too naive #19

RobinClowers opened this issue Nov 20, 2019 · 1 comment

Comments

@RobinClowers
Copy link

Hey there, I really appreciate your tutorial, great stuff.

That said, the way you handle reconciliation leads to bugs if things are conditionally rendered. I've forked your codesandbox to show the issue: https://codesandbox.io/s/didact-8-0l4lz. You should see that clicking the show / hide button will duplicate the count element. Note that if you first increment the count it works correctly, it's not obvious to me why that is.

Cheers!

@sschottler
Copy link

This open PR fixes the issue:
#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants