Drop cppoptlib #66
Merged
Drop cppoptlib #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
- Coverage 89.00% 87.27% -1.73%
==========================================
Files 51 48 -3
Lines 2001 2028 +27
==========================================
- Hits 1781 1770 -11
- Misses 220 258 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I never liked the criteria class, because we couldn't extend it. To me, that is the only thing you copied. I would clean and refactor it a bit, so in the end, it is not a copy paste. Regarding the two LS strategies, we can do without or integrate them in the new framework. Note that they don't properly work with the step valid stuff |
teseoch
reviewed
Jan 30, 2024
Huangzizhou
reviewed
Feb 8, 2024
Huangzizhou
approved these changes
Feb 8, 2024
This was
linked to
issues
Feb 8, 2024
teseoch
reviewed
Feb 9, 2024
teseoch
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this,
but I have mixed feelings about it.Pros:
cppoptlib, so these changes should help avoid downstream conflicts (Is there some special reason to usecppoptlibfrom 2018 instead of the current one? #63)Cons:
cppoptlib(older version) as we use a lot of features inProblembut little inSolverIt still requirescppoptlibfor two line-search methods:CppOptArmijoandMoreThuenteWe can talk about whether to merge these changes here. If not, we can keep the improved comments inProblem.