Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frame in-between previous frames #424

Open
Quinntyx opened this issue Jun 8, 2022 · 3 comments
Open

Add frame in-between previous frames #424

Quinntyx opened this issue Jun 8, 2022 · 3 comments
Labels
feature request New functionality that is wished for feedback Opinion and thoughts to be taken on-board

Comments

@Quinntyx
Copy link

Quinntyx commented Jun 8, 2022

This is a feature request.
The lighting editor should have a feature where you can add a frame that's an average of the selected frame and the frame that would come right after it in chronological order, inserting that frame between the two. In essence, this would simply iterate through each lighting zone, and then average the color set in the previous frame and the color set in the next frame. This feature would be very appreciated simply for smoothly transitioning between two frames, as I have a subtle lighting effect that ends up looking very chunky due to not having enough (only 4) frames, but because there are a lot of colors it's a lot of effort to add more frames in between the two.

Barring this feature, a side-by-side editor would be nice. For example, on the Basilisk Ultimate, the lighting view is shown as a single bar.
image
One really simple feature would be to show the previous frames above and below this bar so that you could pick colors from the previous and make sure that the change is smooth without needing to constantly click back and forth between the frames.

@lah7 lah7 added feature request New functionality that is wished for feedback Opinion and thoughts to be taken on-board labels Jun 8, 2022
@lah7
Copy link
Member

lah7 commented Jun 8, 2022

Thanks for the feedback! Auto-generating frames that transition the colours between 2 frames is a good idea. Sadly, this won't come any time soon since my to-do list is already long. It's been a while since I worked on this project.

Being able to "split" the editor vertically or horizontally (like in a text editor or spreadsheet) to show another frame would be a nice to have. Though, it's sounds a little complicated with the current code base. This probably won't be achieved until I complete the goals of the roadmap. For now, you could open two editors in two different Polychromatic instances (as long as only one is being saved).

There is no device graphic for your hardware, so the grid is your only choice. If you'd like to change that, have a look at contributing a graphic.

I'm curious how users interact with this editor and what kind of effects and colours are being made. If it was me, I would duplicate the frame, use the picker to select the colour and then adjust the hue/saturation/lightness and paint it back, using keyboard shortcuts.

@Quinntyx
Copy link
Author

Quinntyx commented Jun 8, 2022

Auto-generating frames will not be added: understood. I'll look into opening a PR to add it myself then.
Thanks for the quick response!

@lah7
Copy link
Member

lah7 commented Jun 8, 2022

Feel free to create a PR, though a heads up: there is a bunch of refactoring still ongoing (not really with the editor, so that file should be safe)

It's not that it won't be added, there's just a huge backlog of features to build first. The code that will accomplish this will be very useful for future software effect support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New functionality that is wished for feedback Opinion and thoughts to be taken on-board
Projects
None yet
Development

No branches or pull requests

2 participants