Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up yarn version from 1.3.2 to 1.10.0 to get rid of 'deprecated Buffer() constructor' warnings #368

Closed
Stefie opened this issue Oct 17, 2018 · 3 comments
Assignees
Labels

Comments

@Stefie
Copy link
Contributor

Stefie commented Oct 17, 2018

I just did a fresh install and I ran into this issue using Yarn v1.6.0:
yarnpkg/yarn#5477

Older versions of Yarn make use of a deprecated Buffer constructor and therefore throw a security and usability error on install:
(node:88819) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Also see Node docs Deprecated APIs

It was fixed in Yarn 1.10.0, that's why I'd suggest to change the yarn version in engines in the package.json accordingly.

@jacogr
Copy link
Member

jacogr commented Oct 19, 2018

Yes, been driving me crazy (for quite some time). I was not aware it has been fixed, thank you.

@jacogr jacogr added this to the Light client UI milestone Oct 24, 2018
@jacogr jacogr added this to To Do in @polkadot{.js} via automation Oct 24, 2018
@jacogr jacogr self-assigned this Oct 24, 2018
@jacogr
Copy link
Member

jacogr commented Oct 25, 2018

Closed in #379 for the "next" branch, due to go live with poc-3.

@jacogr jacogr closed this as completed Oct 25, 2018
@polkadot{.js} automation moved this from To Do to Done Oct 25, 2018
@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Development

No branches or pull requests

3 participants