Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why pallet-evm requires serde #1351

Open
lemunozm opened this issue Mar 21, 2024 · 0 comments
Open

Why pallet-evm requires serde #1351

lemunozm opened this issue Mar 21, 2024 · 0 comments
Labels

Comments

@lemunozm
Copy link
Contributor

Question

Hi, I want to ask why from polkadot-v1.0.0 you've added the serde feature here: https://github.com/polkadot-evm/frontier/blob/polkadot-v1.0.0/frame/evm/Cargo.toml#L34

This addition makes internally compile sp-runtime with serde, and the MaybeSerializeDeserialize and MaybeSerialize traits now force always to be Serialize. This means that all types in our project now require to be Serialize when it was not required before. It seems like a big change, and I would want to know the reason behind this.

Compiling pallet-evm removing the above requirement compiles without failures. Could that addition be a typo?

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant