Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference between 0i and -0i when used as .rolling() offset #16168

Closed
2 tasks done
cmdlineluser opened this issue May 11, 2024 · 0 comments · Fixed by #16184
Closed
2 tasks done

Difference between 0i and -0i when used as .rolling() offset #16168

cmdlineluser opened this issue May 11, 2024 · 0 comments · Fixed by #16184
Labels
bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars

Comments

@cmdlineluser
Copy link
Contributor

Checks

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of Polars.

Reproducible example

import polars as pl

df = pl.DataFrame({"foo": [1] * 3}).sort("foo").with_row_index()

df.rolling(index_column="foo", period="1i", offset="0i").agg("index")
# shape: (3, 2)
# ┌─────┬───────────┐
# │ foo ┆ index     │
# │ --- ┆ ---       │
# │ i64 ┆ list[u32] │
# ╞═════╪═══════════╡
# │ 1   ┆ []        │
# │ 1   ┆ []        │
# │ 1   ┆ []        │
# └─────┴───────────┘

df.rolling(index_column="foo", period="1i", offset="-0i").agg("index")
# shape: (3, 2)
# ┌─────┬───────────┐
# │ foo ┆ index     │
# │ --- ┆ ---       │
# │ i64 ┆ list[u32] │
# ╞═════╪═══════════╡
# │ 1   ┆ [0, 1, 2] │
# │ 1   ┆ [1, 2]    │
# │ 1   ┆ [2]       │
# └─────┴───────────┘

Log output

No response

Issue description

"positive zero" and "negative zero" offset values behave differently.

The -0i seems to end up equivalent to an "UNBOUNDED FOLLOWING" which some people have requested previously, so could potientially useful - but doesn't seem intended in this case.

Expected behavior

I'm not sure.

Installed versions

--------Version info---------
Polars:               0.20.25
Index type:           UInt32
Platform:             macOS-13.6.1-arm64-arm-64bit
Python:               3.12.2 (main, Feb  6 2024, 20:19:44) [Clang 15.0.0 (clang-1500.1.0.2.5)]

----Optional dependencies----
adbc_driver_manager:  <not installed>
cloudpickle:          <not installed>
connectorx:           <not installed>
deltalake:            <not installed>
fastexcel:            <not installed>
fsspec:               <not installed>
gevent:               <not installed>
hvplot:               <not installed>
matplotlib:           <not installed>
nest_asyncio:         <not installed>
numpy:                1.26.4
openpyxl:             <not installed>
pandas:               2.2.1
pyarrow:              15.0.2
pydantic:             <not installed>
pyiceberg:            <not installed>
pyxlsb:               <not installed>
sqlalchemy:           <not installed>
xlsx2csv:             <not installed>
xlsxwriter:           <not installed>
@cmdlineluser cmdlineluser added bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars labels May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant