Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect external request url building in ASIWebPageRequest #383

Open
pdyakov opened this issue Dec 3, 2013 · 0 comments
Open

Incorrect external request url building in ASIWebPageRequest #383

pdyakov opened this issue Dec 3, 2013 · 0 comments

Comments

@pdyakov
Copy link

pdyakov commented Dec 3, 2013

Issue in ASIWebPageRequest.m
Line: 270 - ASIWebPageRequest *externalResourceRequest = [ASIWebPageRequest requestWithURL:[NSURL URLWithString:theURL relativeToURL:[self url]]];

After this line external resource request url is incorrect. If we download some internal web page, then urls for resources builds as relative to full url instead of base url. This fixes the issue:

ASIWebPageRequest *externalResourceRequest = [ASIWebPageRequest requestWithURL:[NSURL URLWithString:theURL relativeToURL:[[self url] baseURL]]];

Is it a correct solution or something missing?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pdyakov