Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Objective-C modules #8

Open
ninjaprawn opened this issue May 8, 2017 · 4 comments
Open

Adding support for Objective-C modules #8

ninjaprawn opened this issue May 8, 2017 · 4 comments

Comments

@ninjaprawn
Copy link

When writing #5, I thought of an idea of having Objective-C modules, which would allow developers to create modules written in JS (like the default ones), so they can use the Obj-C APIs without needing to expose each API into JS.

After pursuing this idea (I converted the current default modules except for the electrino module), a new folder exists known as modules. Developers would be allowed to drag and drop external modules which are automatically exposed to JS.

This also allows developers to pick and choose specific modules they want, allowing for smaller binary sizes.

I have left just the electrino module within the application. It would most likely be common sense to leave some modules within the application (like console).

Feel free to leave your opinions below :)

@tbodt
Copy link

tbodt commented May 8, 2017

I think it would be a good idea to move as far away from Objective-C/Foundation/Cocoa as possible (see #4). It's likely that to port this thing to other operating systems, most/all of the Objective-C code will have to be ripped out or rewritten in some other language, so let's not write any more of that.

@ninjaprawn
Copy link
Author

The folder structure within the app with Obj-C modules:
Folder Structure

@ninjaprawn
Copy link
Author

@tbodt Hm. I understand this. I guess I'll wait until someone figures out a solution to this. I feel that it will be difficult to implement a universal solution, but who knows what will happen!

@pojala
Copy link
Owner

pojala commented May 22, 2017

Really cool idea. My personal feeling is that it's perfectly ok to do this kind of features in a macOS-specific way because I'd like Electrino apps to always be good citizens of the target platform, rather than an "inner platform" in themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants