Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perceptuallyCompare function has seemingly incorrect operating system check version? #803

Open
msmollin opened this issue Nov 2, 2023 · 0 comments

Comments

@msmollin
Copy link

msmollin commented Nov 2, 2023

Describe the bug
While taking a look at how the library implements fuzzy image match comparison, I noticed that the perceptual comparison function is using CILabDeltaE which per Apple's documentation is only available on iOS 13.0+, tvOS 13.0+, and macOS 10.15+.

However the availability annotations here and here declare earlier OS versions. The reason this doesn't fail to compile is CoreImage using a string-based API for setting up filters makes it impossible to check this at build time (yay objective-c APIs).

I suspect this would cause at best a runtime warning, or at worst a crash, but I don't have my environment setup to test this.

Also as a note the two availability annotations declare different iOS versions, which seems a little disorganized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant