Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request] Avoid automatically recording snapshots on CI #748

Open
NachoSoto opened this issue Jul 20, 2023 · 3 comments · May be fixed by #768
Open

[Request] Avoid automatically recording snapshots on CI #748

NachoSoto opened this issue Jul 20, 2023 · 3 comments · May be fixed by #768

Comments

@NachoSoto
Copy link
Contributor

NachoSoto commented Jul 20, 2023 •
edited

I'm experimenting with moving to Xcode Cloud, and noticed that for some reason it's not finding the snapshots even though they're in the repo.
Because we have test retries enabled, I almost didn't see this, because the second try for every test passed:
Screenshot 2023-07-20 at 13 02 36

It occurs to me that it should be able to disable this behavior when running tests on CI, because the subsequent test run will always be a pass. If there is no snapshot when running tests on CI, it shouldn't try to create them.

Bonus points if there's an environment variable that the library can detect to automatically enable that setting in Xcode Cloud / CircleCI, etc.
@NachoSoto
Copy link
Contributor Author

I just discovered #553
I understand there's nothing that this framework can do to make that automatic, but at least I think it would be nice to make the issue more obvious. If I hadn't noticed the retries I wouldn't have noticed that this was broken.

NachoSoto added a commit to NachoSoto/swift-snapshot-testing that referenced this issue Sep 12, 2023
@NachoSoto
New canGenerateNewSnapshots to avoid automatically creating missing…
3ac85cc 
… ones in CI

Fixes pointfreeco#748.
@NachoSoto NachoSoto linked a pull request Sep 12, 2023 that will close this issue
Open
@alexanderkhitev
Copy link

Hey guys! Any news/updates? Thanks

Open
@Smponias
Copy link

Smponias commented Apr 5, 2024

Any Updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@NachoSoto @alexanderkhitev @Smponias