Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable no-implicit-dependencies #191

Closed
lautarodragan opened this issue Dec 13, 2018 · 1 comment
Closed

Disable no-implicit-dependencies #191

lautarodragan opened this issue Dec 13, 2018 · 1 comment
Assignees

Comments

@lautarodragan
Copy link
Member

I proposed adding this rule in #54 but now I realize it doesn't play well with absolute paths and devDependencies:

WARNING: /usr/src/app/src/API/API.ts[5, 38]: Module 'Configuration' is not listed as dependency in package.json
WARNING: /usr/src/app/src/API/API.ts[6, 36]: Module 'Helpers' is not listed as dependency in package.json
WARNING: /usr/src/app/src/API/API.ts[7, 27]: Module 'Messaging' is not listed as dependency in package.json
WARNING: /usr/src/app/src/API/FileController.test.ts[1, 26]: Module 'riteway' is not listed as dependency in package.json
WARNING: /usr/src/app/src/API/FileController.ts[7, 35]: Module 'Helpers' is not listed as dependency in package.json
WARNING: /usr/src/app/src/API/FileController.ts[8, 39]: Module 'Helpers' is not listed as dependency in package.json
WARNING: /usr/src/app/src/API/FileController.ts[9, 27]: Module 'Helpers' is not listed as dependency in package.json

There's a ton of these messages in the Travis output.

Underlying issue: palantir/tslint#3483

Manually whitelisting paths is not an option for us.

@poet-ci
Copy link

poet-ci commented Dec 20, 2018

🎉 This issue has been resolved in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants