Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question about w #35

Open
zhang-zx opened this issue May 8, 2020 · 7 comments
Open

question about w #35

zhang-zx opened this issue May 8, 2020 · 7 comments

Comments

@zhang-zx
Copy link

zhang-zx commented May 8, 2020

No description provided.

@zhang-zx
Copy link
Author

zhang-zx commented May 8, 2020

Thanks for your excellent work. As stated in your paper, your encoder generates styles code in w space. However, in your code, I think you use z space instead. Maybe there's some setting I overlooked. I hope you can help me understand it better.

@huangzh13
Copy link

I have the same question.

@csxmli2016
Copy link

same question.

@5agado
Copy link

5agado commented Jun 2, 2020

I am also very interested regarding this aspect. Looking at the make_figures scripts, seems indeed you are just passing z to the model.generate function.
At the beginning I thought that the low fidelity of projected images was because of w tiling, but it would be a total different story if your encoder works only to z.

@florian-hoenicke
Copy link

I have the same question. Since w contains more information, using w should improve the reconstructions.

@youngAt19
Copy link

I think actually the author is using w space. The discriminator is implemented as a component in encoder. And the two returning terms of model.encode is w and d's output
图片

@podgorskiy
Copy link
Owner

@youngAt19 is right.
Naming is misleading, that was a result of trying many configurations and things got their names after the writing started. I'll try to fix whatever I can without breaking compatibility with existing models

podgorskiy pushed a commit that referenced this issue Dec 7, 2020
Fixed memory leaking related to matplotlib #17

Hope did not break anything. If you have an issues, try a revision before this commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants