Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After the version 2.7.3 update, SVG parsing loses details。 #217

Open
CodeForRabbit opened this issue Oct 9, 2023 · 6 comments
Open

After the version 2.7.3 update, SVG parsing loses details。 #217

CodeForRabbit opened this issue Oct 9, 2023 · 6 comments

Comments

@CodeForRabbit
Copy link
Contributor

CodeForRabbit commented Oct 9, 2023

test
I lost some SVG details when I updated the 2.7.3 version, See the code after sure is https://github.com/pocketsvg/PocketSVG/commit/42078d1040cb35b45d9af167ad3aa88d8e69e4f2 the problems after the commit, I deleted this update and everything worked fine.

In addition, I found in use that the framework does not support some tags. Such as:

<defs> </defs>

The contents wrapped in these labels cannot be interpreted,
Will these tags be supported in the future?

@CodeForRabbit
Copy link
Contributor Author

Other SVG Settings include: fill-rule
If no difference is made, the filling effect will be different. The corresponding CALayer also has the fillRule attribute, hoping to add compatibility.

@arielelkin
Copy link
Collaborator

Hello @CodeForRabbit

sorry for the delay.

It looks like the only change after that commit was your PR:
42078d1...master

This should only have affected colours. What other information is missing?

@CodeForRabbit
Copy link
Contributor Author

CodeForRabbit commented Nov 14, 2023

I want to error from 42078d1 to submit the while loop line 542 from the beginning.
You can test the butterfly svg in my attachment, parsing it will lose some details.

Uploading 1.svg…

@arielelkin
Copy link
Collaborator

What's the error you're referring to?

@alexacz
Copy link

alexacz commented Jan 16, 2024

I confirm, SVG parsing is corrupted in version 2.7.3.
IMG_0006

@CodeForRabbit
Copy link
Contributor Author

我确认,SVG 解析在 2.7.3 版中已损坏。 IMG_0006

I changed the line:542~557 of the SVGEngine.mm file back to before and everything worked fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants