Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ParseRate logic #285

Closed
JanEricNitschke opened this issue Aug 28, 2023 · 1 comment · May be fixed by #287
Closed

Change ParseRate logic #285

JanEricNitschke opened this issue Aug 28, 2023 · 1 comment · May be fixed by #287

Comments

@JanEricNitschke
Copy link
Collaborator

Currently parse rate sets the fraction of recorded frames that makes it into the json.

A parse rate of 1 means every single frame makes it into the json while 128 means every 128th frame makes it in.

This has the disadvantage that it leads to fluctuating frames per second depending on the demo tickrate. If one parses demos from different sources some demos will have 1 frame per second while other would only have one frame every 4 or so seconds.

We could change (or offer an alternative) the logic the specify the (maximum) number of frames per second instead.
That way one could specify 1 frame per second and would always get a consistent value (as long as the demo permits).

Setting values of more frames per second than what was recorded in the demo would emit a warning and instead just record every single frame instead as a best effort.

What are your thoughts on this?

@pnxenopoulos
Copy link
Owner

Closing for Awpy 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants