Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FeatureRequest] Handle map download with multiple instances. #458

Open
BiatuAutMiahn opened this issue Oct 31, 2023 · 0 comments
Open

[FeatureRequest] Handle map download with multiple instances. #458

BiatuAutMiahn opened this issue Oct 31, 2023 · 0 comments

Comments

@BiatuAutMiahn
Copy link

Using Nucleus CoOp, attempting to play with more than 1 instance. All players log in, and go to join game lobby.

Scenario 1:
Nobody has the map. Everyone is prompted to download the map. Map is downloaded then fails due to file being locked by another instance.

Scenario 2:
Nobody has map. Instance 1 downloads map. All other instances prompt for download as they do not check for maps except for on init.

Scenario 3:
Map exists in custom maps dir. All is good,

And a few proposed solutions:

1:

if (instanceNumber) {
    while (peer_count_with_map_status_downloading) {
        ReloadAllMaps();
        // wait 1000ms
    }
    // Return true for map being downloaded.
}

2:
if instanceNumber==0, and isMultiInstance: download map to .part file instead of .map, wait for peer_count_with_map_status_downloading==0.
with instanceNumber>0 wait for .part to not exist. then return true for download complete.

3:
postfix custom_maps_folder_path with instance number before download if isMultiInstance, instanceNumber>0, and map does not exist in custom_maps_folder_path.

@BiatuAutMiahn BiatuAutMiahn changed the title [FeatureRequest] Handle Map Download with multi-instance. [FeatureRequest] Handle Map Download with multiple instances. Nov 1, 2023
@BiatuAutMiahn BiatuAutMiahn changed the title [FeatureRequest] Handle Map Download with multiple instances. [FeatureRequest] Handle map download with multiple instances. Nov 1, 2023
@Berthalamew Berthalamew self-assigned this Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants