Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetaLoader] Sound Injection Support #240

Open
Himanshu-01 opened this issue Jul 14, 2019 · 0 comments
Open

[MetaLoader] Sound Injection Support #240

Himanshu-01 opened this issue Jul 14, 2019 · 0 comments

Comments

@Himanshu-01
Copy link
Contributor

Sound tags are handled differently than other tags
This is something that cannot be made possible by just injected the raw data(as was the case for jmad) or pointing it to the appropriate map file (as was the case for raw datas)

the snd! tag group points to the tag blocks present the ugh! tag

image

image

If the index value present in snd! tag is out of bounds(more than MAX_ELEMENTS in ugh!) then it causes the game to crash abruptly.
Current Solution is to remap the indices to lower value SoundFixCommitDetails

The global_tag_interface system can be used to add or remove tag blocks. So this may get fixed.But there are more locations the sound tag is used referred to.
This needs to be looked further into

@nukeulater nukeulater changed the title [MetaLoader]Sound Injection Support [MetaLoader] Sound Injection Support Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants