Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SurfaceSmoothing introduces NAN vertices #28

Open
cdcseacave opened this issue Jun 17, 2020 · 3 comments
Open

SurfaceSmoothing introduces NAN vertices #28

cdcseacave opened this issue Jun 17, 2020 · 3 comments

Comments

@cdcseacave
Copy link

cdcseacave commented Jun 17, 2020

For some meshes the smoothing creates vertices with NAN position.
Windows 10 x64, Visual Studio

Ex mesh:

pmp::SurfaceSmoothing smoother(mesh);
smoother.explicit_smoothing(2, false);

creates 8 NAN vertices:

invalid vertex 3991526 position: -nan(ind) -nan(ind) -nan(ind)
invalid vertex 3991527 position: -nan(ind) -nan(ind) -nan(ind)
invalid vertex 3991532 position: -nan(ind) -nan(ind) -nan(ind)
invalid vertex 3991542 position: -nan(ind) -nan(ind) -nan(ind)
invalid vertex 3991557 position: -nan(ind) -nan(ind) -nan(ind)
invalid vertex 3991559 position: -nan(ind) -nan(ind) -nan(ind)
invalid vertex 3991562 position: -nan(ind) -nan(ind) -nan(ind)
invalid vertex 3991563 position: -nan(ind) -nan(ind) -nan(ind)
@cdcseacave
Copy link
Author

I found the cause for this particular ex: some degenerate faces. However PMP does not offer a way to detect and fix such problems.

@dsieger
Copy link
Member

dsieger commented Jul 6, 2020

Hi,

As you already found out, this is most likely due to degenerate faces in the input mesh. We'll eventually add some way to prevent / detect this in a future version.

Thanks,
Daniel

@dsieger
Copy link
Member

dsieger commented Jul 6, 2020

Reopen and mark as enhancement

@dsieger dsieger reopened this Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants