Issue in hole filling algorithm

[thovide]

Hello,

the catch in hole filling code is using the wrong exception:

try
    {
        triangulate_hole(h); // do minimal triangulation
        refine();            // refine filled-in edges
    }
    catch (InvalidInputException& e)
    {
        // clean up
        hole_.clear();
        mesh_.remove_vertex_property(vlocked_);
        mesh_.remove_edge_property(elocked_);

        throw e;
    }

hole triangulation can raise topological exceptions. Then they're not catched and you don't clean the added properties. Which makes further usage of hole filling algorithm impossible (properties cannot be added anymore)

[dsieger]

Thanks for reporting. This needs some thought though.

triangulate_hole() itself is only throwing an InvalidInputException in case of a non-manifold hole, which would be a violation of the input precondition. SurfaceMesh::add_face() — called in triangulate_hole() — can throw a TopologyException. I think it should be the responsibility of the direct caller to catch those.