Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-spring, ordering and decoupling #65

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

react-spring, ordering and decoupling #65

wants to merge 16 commits into from

Conversation

bbohlender
Copy link
Contributor

@bbohlender bbohlender commented Sep 12, 2021 •
edited

fix #8, #16
should improve #7

  • decouples from three.js with useBox
  • integrates with react-spring enabling useSpringBox
  • offers Box and SpringBox and is extensible for more Box types using useBox hooks
  • intergrates odering management using index

Breaking changes:

  • BoxReferenceGroup instead of Flex being the automatic reference group
  • use "AutomaticBox" instead of a normal "Box" to enable automatic size computation based on bounding box of children
  • Flex has no "inner" group, thus a flex element can't be translated (however a surrounding group can be of course)

I'd love to discuss the proposed changes. I've tested them using the storybook stories and already used it on a XR-UI library I am writing (https://twitter.com/BelaBohlender/status/1433844465450508288).

@bbohlender bbohlender mentioned this pull request Sep 12, 2021
Closed
@talentlessguy
Copy link
Member

lint action seems to still fail

@bbohlender
Copy link
Contributor Author

lint action seems to still fail

yeah, I am not using yarn, so the lock file had to be updated,
should be all set now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React-spring compatibility
2 participants
@bbohlender @talentlessguy