Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convergence criterion #940

Open
IvarStefansson opened this issue Aug 17, 2023 · 2 comments
Open

Convergence criterion #940

IvarStefansson opened this issue Aug 17, 2023 · 2 comments
Assignees
@mariusnevland
Labels
user group Issue to be worked on in the internal user group.

Comments

@IvarStefansson
Copy link
Contributor

The current default convergence criterion is based on the iteration solution update. I suggest we consider replacing it with a residual based one. This might wait for the planned AD parsing overhaul which hopefully allows for evaluation of the residual without re-computing the Jacobian.
@IvarStefansson IvarStefansson added the user group Issue to be worked on in the internal user group. label Aug 17, 2023
@keileg
Copy link
Contributor

keileg commented Aug 24, 2023

Based on input from @jwboth, we should also consider monitoring the residual for individual equations, rather than only for the full system.

@jwboth jwboth self-assigned this Aug 24, 2023
@mariusnevland mariusnevland self-assigned this Aug 24, 2023
@jwboth jwboth removed their assignment Oct 19, 2023
@IvarStefansson
Copy link
Contributor Author

This is now facilitated. Let's make a decision on whether to make residual based convergence default, @keileg and @jwboth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariusnevland mariusnevland

Labels
user group Issue to be worked on in the internal user group.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@keileg @IvarStefansson @pschultzendorff @jwboth @mariusnevland