You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To map between faces and cells in a grid, we currently have the following functionality:
fvutils.scalar_divergence, fvutils.vector_divergence are two separate methods that are not exclusive to finite volume methods. Also, the methods could be parametrized, as is done in pp.ad.GridOperators.Divergence
There is occasional usage of a trace operator, see for instance pp.Upwind. There is however no ready functionality to get hold of a discrete trace operator (independent of dimension).
Note that this does not concern the Ad module, where the code is much cleaner (at least in a certain sense).
Suggested improvement:
The current functions fvutils.scalar_divergence, fvutils.vector_divergence are moved to pp.Grid and parametrized with dimension, so that one can write pp.Grid(...).divergence(dim: int=n)
The grid class is further equipped with methods trace(dim:int) and inv_trace(dim: int).
The new methods are taken into use throughout the code. That should be straightforward for the divergence, but searching for usage of trace operators may require some care.
The text was updated successfully, but these errors were encountered:
To map between faces and cells in a grid, we currently have the following functionality:
fvutils.scalar_divergence
,fvutils.vector_divergence
are two separate methods that are not exclusive to finite volume methods. Also, the methods could be parametrized, as is done inpp.ad.GridOperators.Divergence
pp.Upwind
. There is however no ready functionality to get hold of a discrete trace operator (independent of dimension).Note that this does not concern the Ad module, where the code is much cleaner (at least in a certain sense).
Suggested improvement:
fvutils.scalar_divergence
,fvutils.vector_divergence
are moved topp.Grid
and parametrized with dimension, so that one can writepp.Grid(...).divergence(dim: int=n)
trace(dim:int)
andinv_trace(dim: int)
.The text was updated successfully, but these errors were encountered: