add "?amp" instead of "/amp/" for AMP visit tracking (#183) #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stklcode
force-pushed
the
fix/183-amp-url
branch
from
177ce62
to
d5ca4f2
Compare
stklcode
force-pushed
the
fix/183-amp-url
branch
from
d5ca4f2
to
79255c6
Compare
pfefferle
reviewed
Jul 19, 2021
pfefferle
reviewed
Jul 19, 2021
stklcode
force-pushed
the
fix/183-amp-url
branch
from
f93a709
to
5d75670
Compare
stklcode
force-pushed
the
fix/183-amp-url
branch
from
5d75670
to
01458e8
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one possible way to fix #183
Instead of adding
/amp/to the URL of the page is accessed via AMP, we now add?amp.This is always fine, because AMP should never provide other URL parameters.
Depending on the outcome of the discussion in #183 we can either merge this PR or close it. Just opened, so we don't do the work twice if needed.