Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluck code bloat - Pluck Improvements #18

Open
ekyo-pl opened this issue Oct 8, 2014 · 1 comment
Open

Pluck code bloat - Pluck Improvements #18

ekyo-pl opened this issue Oct 8, 2014 · 1 comment
Milestone

Comments

@ekyo-pl
Copy link
Contributor

ekyo-pl commented Oct 8, 2014

Due to forum discusion

Kevin Rubio (http://www.phphelp.com/forum/pluck-cms/pluck-improvements/):

  1. Admin.php file - In admin.php from lines 62 to 285 you have repeated "include_once('data/inc/header.php');" THIRTY TWO times. Since every single case has it, you only need to do it ONCE right before you start your switch.
  2. Pluck uses sha512 for password encryption. Should be using bcrypt.
  3. http://www.phphelp.com/forum/pluck-cms/pluck-improvements/msg84599/#msg84599 Redirect function
  4. Magic quotes "All the code for magic quotes should not even be there. Magic quotes is Deprecated."

Topcoder (http://www.phphelp.com/forum/pluck-cms/plan-for-pluck-cms-4-8/):

  1. Reducing the number of requests for images by using sprites and CSS.
@ekyo-pl ekyo-pl added this to the 4.8 milestone Oct 8, 2014
ekyo-pl added a commit that referenced this issue Oct 13, 2014
@Uranium235
Copy link

"All the code for magic quotes should not even be there"
What is that supposed to mean? There is no code to use magic quotes in pluck. On the contrary, it checks to make sure magic quotes are in fact not enabled. Don't see anything wrong with that. Thank the folks who came up with the idea, don't blame the ones who still have to deal with it.
If we want to remove that code completely, pluck will only be compatible with PHP versions that have no way of enabling magic quotes. That is the idea behind "deprecated": you do not use it anymore, but you still might have to deal with it until it's impossible to come up again. I am not sure that is the case yet.

There is one thing though: requirements.php should check if the function get_magic_quotes_gpc() is defined before making a call, like security.php does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants