Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Dash auto rotation config is set to ms when it should be seconds. #12

Open
muffinresearch opened this issue Mar 31, 2017 · 2 comments

Comments

@muffinresearch
Copy link

item info notes
node version v6.9.5 output from node --version
npm version 3.10.10 output from npm --version
mozaik-demo version f296609 (v2) git ref of the demo
browser N/A browser used, applyable if the issue is not related to the client

Expected behavior

Dashboard rotation to work

Actual behavior

Dashboard rotation doesn't appear to work.

Steps to reproduce

  • Run rev f296609
  • Add a second dashboard to config
  • Note auto rotation doesn't work even when pressing the play/pause
@muffinresearch muffinresearch changed the title Dash auto rotation doesn't function [v2] Dash auto rotation doesn't function Mar 31, 2017
@muffinresearch
Copy link
Author

Actually there isn't any issue with rotation - the problem is that the time is set in ms when in fact it should be seconds.

https://github.com/plouc/mozaik-demo/blob/mozaik-2/config.yml#L12

So this default setting is just exceptionally long and it appears to not be working. Setting something shorter it works fine.

@muffinresearch muffinresearch changed the title [v2] Dash auto rotation doesn't function [v2] Dash auto rotation config is set to ms when it should be seconds. Apr 28, 2017
@przemuh
Copy link

przemuh commented Jan 30, 2019

Fixed in #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants