Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation issue of valueFilter? #151

Open
aboulang opened this issue Jul 9, 2022 · 0 comments
Open

Implementation issue of valueFilter? #151

aboulang opened this issue Jul 9, 2022 · 0 comments

Comments

@aboulang
Copy link

aboulang commented Jul 9, 2022

I think this may be an implementation issue. From what I can tell the intent was for

var valueFilter = {"Colors":{"Green": true}};

to do what gmacias711 expected in #68. Looks like Nicolas merged inclusions and exclusions parameters from pivotable.js (see https://github.com/nicolaskruchten/pivottable/wiki/Parameters about Pivotable.js's inclusions and exclusions parameters ) into one valueFilter but it is not handling the inclusions side correctly. It can be cumbersome to have to collect all the exclusions instead of what should be included -- especially if valueFilter is a prop that currently can not be modified! The true value not working as expected and therefore having to collect all the values to set to false when the Pivotable is first created is biting me.

Originally posted by @aboulang in #68 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant