Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept app root path as kwarg to dash() method #233

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

tanmaykm
Copy link

Allow the app root path to be specified explicitly for the dash() method. The default is app_root_path() and does not break compatibilty.

fixes: #232

Allow the app root path to be specified explicitly for the `dash()` method. The default is `app_root_path()` and does not break compatibilty.

fixes: plotly#232
@tanmaykm
Copy link
Author

CI failed in the "Install Chromedriver" step here... seems unrelated to changes in the PR?

@etpinard
Copy link
Collaborator

@tanmaykm thanks very much for this PR!

I got the tests to pass again with #234, merging the latest dev into your branch and pushing again should give you a clean test run.

I'll need to double-check how app_root_path works in the python of dash before approving this PR.

@etpinard
Copy link
Collaborator

There's no app_root_path kwarg for the python Dash class

Ref: https://github.com/plotly/dash/blob/f70b3db6312c084206054cd903ee644359009486/dash/dash.py#L184-L357

We try as much as we can to have the Julia dash constructor mimic the python Dash class. So, I doubt we'll be able to accept this PR in its current form unfortunately 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept app root path as kwarg to dash method?
2 participants