Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra tests for callback processing #142

Open
waralex opened this issue Oct 25, 2021 · 0 comments
Open

Extra tests for callback processing #142

waralex opened this issue Oct 25, 2021 · 0 comments

Comments

@waralex
Copy link
Collaborator

waralex commented Oct 25, 2021

From comment on #140 :

If you felt like being extra-paranoid with tests (but I don't think this is necessary for this PR) there are a couple more cases we could in principle cover:

  • Both in the single- and multi-output cases, have ALL match only a single element. Note this could be done by creating a new request to the same apps as in the new test and the one you just clarified the name, as we can assume the layout was changed as a result of some other callback.
  • A real multi-output callback, where one output is a regular string ID and the other one is an ALL that matches no elements at all, such that the callback should return an empty list for that second output. Note that if it's a single-output callback with just an ALL that matches no elements, the callback will never be triggered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant