Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UID to the metadata for summaries, for example related items. #1586

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add UID to the metadata for summaries, for example related items. #1586

wants to merge 1 commit into from

Conversation

mauritsvanrees
Copy link
Sponsor Member

Fixes #1585

TODO: fix tests.

@mister-roboto
Copy link

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@netlify
Copy link

netlify bot commented Feb 16, 2023 •
edited

✅ Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit b12a6d1
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/63ee4f16d395740008d73e59

@mauritsvanrees mauritsvanrees mentioned this pull request Feb 16, 2023
Open
@davisagli
Copy link
Sponsor Member

Note: This was added for serialized RelationValues in #1605. I think this change is probably still desirable, in order to include the UID in other places that use the summary serializer. But the tests need to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
25 status: deferred
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

why does the RelationValue serializer not add the UID of the item?
4 participants
@mauritsvanrees @mister-roboto @davisagli @tisto