Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forceful sms_type setting to text causing to prevent using flash sms feature #659

Closed
damithkothalawala opened this issue Jan 20, 2024 · 1 comment
Closed

Forceful sms_type setting to text causing to prevent using flash sms feature #659

damithkothalawala opened this issue Jan 20, 2024 · 1 comment

Comments

@damithkothalawala
Copy link
Contributor

Dear @antonraharja,

1st of all thank you very much for your contribution for opensource community.

While doing some testing on flash sms, I found a small bug which is causing to prevent sending flash sms via the helper. I have just commented it and tested, works fine. Will raise a pr with the fix soon.

playsms/storage/application/plugin/core/sendsms/fn.php

Line 769 in 179e460

if ($sms_type != 'text') {

Thank you again.
damithkothalawala added a commit to damithkothalawala/psms_bugfixes that referenced this issue Jan 20, 2024
@damithkothalawala
fixing Issue playsms#659 Forceful sms_type setting to text
59241b4 
Just commenting out the error causing lines
@damithkothalawala damithkothalawala mentioned this issue Jan 20, 2024
Merged
antonraharja added a commit that referenced this issue May 20, 2024
@antonraharja
Merge pull request #660 from damithkothalawala/master
464811a 
fixing Issue #659  Forceful sms_type setting to text
@damithkothalawala
Copy link
Contributor Author

Thank you @antonraharja

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@damithkothalawala