Incorrect calculation the column of error for template with first line comments

[ihostage]

No description provided.

[mkurz]

Can you give more detail or an example?

[ihostage]

Sorry, Matthias @mkurz . I didn't have time to finish it yesterday. Just I needed an issue number for cross-link in another PR with adding copyrights.

Can you give more detail or an example?

Example right now is had in our tests, that were broken when I added copyrights header to twirl templates 😞

twirl/compiler/src/test/scala/play/twirl/compiler/test/CompilerSpec.scala

Lines 174 to 189 in 7b6c41d

	"fail compilation for error.scala.html" in {
	val helper = newCompilerHelper
	the[CompilationError] thrownBy helper.compile[(() => Html)]("error.scala.html", "html.error") must have(
	Symbol("line")(2),
	Symbol("column")(12)
	)
	}
	"fail compilation for errorInTemplateArgs.scala.html" in {
	val helper = newCompilerHelper
	the[CompilationError] thrownBy helper
	.compile[(() => Html)]("errorInTemplateArgs.scala.html", "html.errorInTemplateArgs") must have(
	Symbol("line")(1),
	Symbol("column")(6)
	)
	}

It is related with that Twirl use first comment block as comments for constructor args and has a special behavior for this comments. Yesterday I hadn't found a quick and nice solution for this bud and decided move this to separate issue because I don't think that it's a stopper to merge #568 🤷‍♂️