Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for play.crypto.secret & application.secret in 2.7.x #8981

Closed
naferx opened this issue Jan 22, 2019 · 3 comments · Fixed by #9061
Closed

Remove support for play.crypto.secret & application.secret in 2.7.x #8981

naferx opened this issue Jan 22, 2019 · 3 comments · Fixed by #9061
Labels
good first issue help wanted
Milestone
Play 2.8.0-M1

Comments

@naferx
Copy link
Contributor

naferx commented Jan 22, 2019

They have been marked as deprecated for a while

application.secret since https://www.playframework.com/documentation/2.4.x/Migration24#Configuration-changes and play.crypto.secret since https://www.playframework.com/documentation/2.6.x/Migration26#Other-Configuration-changes
@marcospereira
Copy link
Member

A pull request would be very welcomed here.

@naferx
Copy link
Contributor Author

naferx commented Jan 24, 2019

A PR will be arriving ;)

chipz added a commit to chipz/playframework that referenced this issue Feb 21, 2019
@chipz
### Fixes
6737262 
Fixed playframework#8981 playframework#8981

Removed `play.crypto.secret` & `application.secret` leaving `play.http.secret.key` as the only way to set secret key
@chipz chipz mentioned this issue Feb 22, 2019
Merged
@chipz
Copy link
Contributor

chipz commented Feb 22, 2019

Hi guys, I created a PR on removing the play.crypto.secret and application.secret on #9061

marcospereira pushed a commit that referenced this issue Feb 24, 2019
@chipz @marcospereira
Remove application.secret and play.crypto.secret support (#9061)
60c0de7 
* ### Fixes

Fixed #8981 #8981

Removed `play.crypto.secret` & `application.secret` leaving `play.http.secret.key` as the only way to set secret key

* - Removed ActualKeySecretConfigurationParserSpec and changed SecretConfigurationParserSpec from trait to class
- Changed getDeprecated to get as we removed deprecated code
@dwijnand dwijnand added this to the Play 2.8.0-M1 milestone May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
Play 2.8.0-M1
Development

Successfully merging a pull request may close this issue.

Remove application.secret and play.crypto.secret support chipz/playframework
4 participants
@marcospereira @chipz @dwijnand @naferx