Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hookbox breaks when using a websocket enabled browser on a secure connection (https) #68

Open
mallio opened this issue Sep 14, 2010 · 1 comment

Comments

@mallio
Copy link

mallio commented Sep 14, 2010

Hookbox does not use a valid websocket url when on a secure connection. The issue is on line 16 of hookbox.js.

The protocol for secure websockets is wss://, so that code could be changed to be:

url.replace('http://', 'ws://').replace('https://', 'wss://')

or
url.replace(/http(s)?:///, 'ws$1://')

@krims0n32
Copy link

Confirming this, with Chrome, and that the workaround above seems ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants