Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the docker-based GHA into a composite action #9

Open
webknjaz opened this issue Dec 13, 2021 · 2 comments
Open

Convert the docker-based GHA into a composite action #9

webknjaz opened this issue Dec 13, 2021 · 2 comments

Comments

@webknjaz
Copy link
Contributor

I think it would be reasonable to refactor the GHA to use a better action type. Docker is limited to Ubuntu workers and has a certain amount of runtime overhead that I believe can be addressed with Composite GitHub Actions. I've promptly checked the current setup and I don't believe there's anything that is tightly coupled with the docker runtime and can't be substituted.

Ref: https://docs.github.com/en/actions/creating-actions/creating-a-composite-action

@platisd
Copy link
Owner

platisd commented Dec 13, 2021

I also think it'd work and would improve the run times.
Feel free to submit a PR! 👍

@webknjaz
Copy link
Contributor Author

Here's an example of using gitlint instead of this action: https://github.com/cherrypy/cheroot/pull/579/files. Maybe somebody interested in this will get some inspiration from that patch. I'm moving away from using this action for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants