Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor runtime loggingPort usage #2127

Open
ivan-tymoshenko opened this issue Feb 19, 2024 · 0 comments
Open

Refactor runtime loggingPort usage #2127

ivan-tymoshenko opened this issue Feb 19, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ivan-tymoshenko
Copy link
Member

IMHO user should not create a MessageChannel and attach it to the config file to use in runtime later how it's done in the test here:
https://github.com/platformatic/platformatic/blob/main/packages/runtime/test/start/logs-errors-during-migrations.test.js

Instead there should be a config option to set. If option is set, runtime should create a MessageChannel channel, attach it to the runtime instance, so user can use it later.

@ivan-tymoshenko ivan-tymoshenko added the enhancement New feature or request label Feb 19, 2024
@ivan-tymoshenko ivan-tymoshenko self-assigned this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant