Skip to content
This repository has been archived by the owner on Jun 10, 2019. It is now read-only.

Remove git dependencies from package.json #45

Open
karlfloersch opened this issue Feb 9, 2019 · 2 comments
Open

Remove git dependencies from package.json #45

karlfloersch opened this issue Feb 9, 2019 · 2 comments
Labels
cleanup good first issue Good for newcomers

Comments

@karlfloersch
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Here we install a few git repositories during the npm install process -- https://github.com/plasma-group/plasma-chain-operator/blob/master/package.json#L56-L58 . This isn't ideal considering there's no version tracking.

Describe the solution you'd like
Replace this with direct references to the npm package with version number.

@endziu
Copy link

endziu commented Feb 15, 2019

I can take care of it.
but it looks like plasma-explorer is not on npm.
Should I submit a pull request with only plasma-contract and plasma-utils updated ?

@karlfloersch
Copy link
Contributor Author

Amazing! Yes actually you can remove plasma-explorer generally. It's not being used at the moment & I just forgot to take it out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cleanup good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants