Skip to content
This repository has been archived by the owner on Jun 10, 2019. It is now read-only.

Extract tx-log ingestion logic out of block-store #44

Open
karlfloersch opened this issue Feb 9, 2019 · 0 comments
Open

Extract tx-log ingestion logic out of block-store #44

karlfloersch opened this issue Feb 9, 2019 · 0 comments
Labels
cleanup good first issue Good for newcomers

Comments

@karlfloersch
Copy link
Contributor

karlfloersch commented Feb 9, 2019

Is your feature request related to a problem? Please describe.
Currently block-store.js handles way more than it should. It ingests transactions from the tx-log, triggers the leveldb-sum-tree logic, and generates history proofs. This is too much.

Describe the solution you'd like
The first step in cleaning up the block-manager is extracting the tx-log ingestion logic. tx-log ingestion should be a separate file which one can call, pass in a db and then wait util that db is populated with transactions from a particular block. This is a very clean separation of concerns and should be easy to pull out.

Relevant code: https://github.com/plasma-group/plasma-chain-operator/blob/master/src/block-manager/block-store.js#L365-L452

@karlfloersch karlfloersch changed the title Extract tx-log ingestion logic out of block-manager Extract tx-log ingestion logic out of block-store Feb 9, 2019
@karlfloersch karlfloersch added the good first issue Good for newcomers label Feb 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cleanup good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant