Skip to content
This repository has been archived by the owner on Jun 10, 2019. It is now read-only.

getTransactions returns deposits as transactions #43

Open
smartcontracts opened this issue Feb 9, 2019 · 2 comments
Open

getTransactions returns deposits as transactions #43

smartcontracts opened this issue Feb 9, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@smartcontracts
Copy link
Contributor

Describe the bug
When I make calls to getTransactions, I'm getting back transactions with a null address as the sender (0x000....) which represent deposits. I don't think these should be returned in getTransactions since I can (and should) get deposits from the contract, not the operator.

Steps to reproduce
Steps to reproduce the behavior:

  1. Make a deposit for an address.
  2. Query transactions for that address using getTransactions.
  3. Get back the deposit as a transaction.

Expected behavior
getTransactions should not return deposits.

@smartcontracts smartcontracts added the bug Something isn't working label Feb 9, 2019
@karlfloersch
Copy link
Contributor

karlfloersch commented Feb 9, 2019

@kfichter do you need the deposit blocks? Like the Ethereum block that the deposit was made? If I remember correctly that's why we were returning deposits. Hopefully we don't because that removing it would for sure clean up the code

@smartcontracts
Copy link
Contributor Author

Like the Ethereum block that the deposit was made?

I need the deposits for history proofs, but nowhere else.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants