Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP-712 #549

Open
fubuloubu opened this issue Nov 24, 2019 · 0 comments
Open

Add EIP-712 #549

fubuloubu opened this issue Nov 24, 2019 · 0 comments

Comments

@fubuloubu
Copy link

fubuloubu commented Nov 24, 2019

It's important for the safety of user funds to use a domain separation technique in order to protect the signing context of a person's account, especially if the OVM technique is to see wider use. EIP-712 has a lot of adoption (metamask and other wallets have integrated, dedicated opcode for chain ID in Istanbul, currently being finalized, etc.) so it would be a great suggestion to manage domain separation of the meta-txns/L2 signed messages that OVM produces. It is fairly easy to integrate, requiring only a marginal growth in the complexity of signature verification in on-chain smart contracts. However, it would give a stable API endpoint that can be targeted in Web3 providers to ensure the safety of user keys, which is a much larger benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant